Bugfix removed for BMP280 on Domoticz

Moderators: rtenklooster, Voyager, BertB, Stuntteam

Forum rules
You have entered the experimental forum, beware!!!
Post Reply
Message
Author
flashmark
New user
Posts: 1
Joined: 17 Feb 2018, 20:14

Bugfix removed for BMP280 on Domoticz

#1 Post by flashmark » 17 Feb 2018, 20:26

I discovered a Bug in the handling of BMP280 (temp+baro) sensor when sending the values to Domoticz.
It was already discovered and solved according to issue: [Domoticz HTTP] Compatibility fix for BMP280 (#636)
I checked the Github repository and the solution has been wrongfully merged between mega and 2.0.0. File: src/_C001.ino Lines 98..103. Can you restore the original fix in both releases?
I don't have enough experience with Github and ESPEasy way of working with branches to get this right myself at the moment. I did fix it in my own copy of the source code.
Thanks for this great piece of software.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Bugfix removed for BMP280 on Domoticz

#2 Post by TD-er » 17 Feb 2018, 21:48

So it is wrong on the Mega branch, and only in c001? Not in c002? (both Domoticz)

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Bugfix removed for BMP280 on Domoticz

#3 Post by TD-er » 17 Feb 2018, 22:31

I created an issue for it on Github: https://github.com/letscontrolit/ESPEasy/issues/890

I am already thinking about renaming the issue to fix some more, since there are several more that appear different.

The last sentence of this paragraph suggests the order of the values should be the same for HTTP and MQTT: https://www.domoticz.com/wiki/MQTT#Domoticz_to_MQTT
And there are more examples in which they are not the same.

TD-er
Core team member
Posts: 8643
Joined: 01 Sep 2017, 22:13
Location: the Netherlands
Contact:

Re: Bugfix removed for BMP280 on Domoticz

#4 Post by TD-er » 18 Feb 2018, 00:52

Added a pull request #891
Please test these with as many sensors as possible.
At least it should not matter anymore if HTTP or MQTT Domoticz controller is used.

Post Reply

Who is online

Users browsing this forum: No registered users and 2 guests