settings dropped after upgrade to build 20230930

[Rob73]

I noticed on my D1 mini modules when I recently upgraded the firmware to ESP_Easy_mega_20230930_normal_ESP8266_4M1M, it dropped some settings previously set. On the controllers page, Send LWT to broker & Will Retain settings were checked before the upgrade and unchecked after flash.

This evening I setup a test module & did some before and after checks. It dropped them on my test module too when going from the last build to 20230930.

May be just something going on with my stuff but folks may want to keep an eye on it if you use lwt on your mqtt setups & you notice they arent working.


Rob

[TD-er]

Hmm that's good to know there is an issue with this.
Given what I have changed in the code (to reduce build size quite a lot), I think there is a chance I may have messed up here.
I will have a look later this evening to see if I may have missed a bit (literally) when adapting all those get/set functions to a union struct.

[TD-er]

I looked at the code and I see where I messed up.
Apparently those 2 were the only ones where the stored value has to be negated.

I will correct these. But I'm not sure whether I should patch existing settings.
I think there should be a fix in the code and a new build along with clear description of what is fixed so users who changed settings only in the last build will have to correct it.

[TD-er]

Made a fix for it and I think I will make a new build later this evening: https://github.com/letscontrolit/ESPEasy/pull/4848