P012 plugin - LCD display

[mackowiakp]

As I can see in the sources, it is possible to define Polish characters in the LCD display.

Code: Select all

[maciek@Piotr src]$ grep -R USES_P012_POLISH *
src/PluginStructs/P012_data_struct.cpp:# ifdef USES_P012_POLISH_CHARS
src/PluginStructs/P012_data_struct.cpp:# endif // USES_P012_POLISH_CHARS
src/PluginStructs/P012_data_struct.cpp:# ifdef USES_P012_POLISH_CHARS
src/PluginStructs/P012_data_struct.cpp:# endif // ifdef USES_P012_POLISH_CHARS
src/PluginStructs_tmp/__tmpfile.cpp:# ifdef USES_P012_POLISH_CHARS
src/PluginStructs_tmp/__tmpfile.cpp:# endif // USES_P012_POLISH_CHARS
src/PluginStructs_tmp/__tmpfile.cpp:# ifdef USES_P012_POLISH_CHARS
src/PluginStructs_tmp/__tmpfile.cpp:# endif // ifdef USES_P012_POLISH_CHARS

What and where to add to the plugin source to be able to compile FW with this function?

[TD-er]

Where you also define what plugin to use (e.g. USES_P012), you also define the USES_P012_POLISH_CHARS

Code: Select all

#define USES_P012
#define USES_P012_POLISH_CHARS

Or if you're using the Python files to define your custom build:

Code: Select all

"-DUSES_P012",
"-DUSES_P012_POLISH_CHARS",

[mackowiakp]

OK, THX, Will try later and rapport results.

[mackowiakp]

Polish letters are display properly both on 2x16 and 4x20 display.
But there is another problem.
So far I used FW compiled 3 or more years ago, with Polish letter feature made on my own. It works properly.
Now there is in logs such command:

Code: Select all

LCD,1,1,10:26 Wt. 7/03/23
or
LCD,4,1,Wewn. 20.3° VOC 299

The command above are created by rules:

Code: Select all

LCD,1,1,%systm_hm% Wt. %sysday%/%sysmonth_0%/%sysyears%
and
LCD,4,1,Wewn. [Temp-Higro#Temperatura-Piotr#D1.1]{D} VOC [VOC-Piotr#VOC-Piotr]

But only "10:26" and "Wewn." is shown on display.
Looks like something wrong with spaces interpretation.
How can I fix it?

[Ath]

You need to add quotes around the part that is supposed to be displayed, that can either be double quotes, single quotes or back-ticks. Just use one that's not used in the content. See: https://github.com/letscontrolit/ESPEasy/issues/2724

Code: Select all

LCD,1,1,"%systm_hm% Wt. %sysday%/%sysmonth_0%/%sysyears%"
and
LCD,4,1,"Wewn. [Temp-Higro#Temperatura-Piotr#D1.1]{D} VOC [VOC-Piotr#VOC-Piotr]"

[mackowiakp]

Yep, now is a lot of better
THX for quick feedback !

[mackowiakp]

Another problem.
When I try to send LCD command to unit with 4x20 display, using such command from bash scipt on Rpi:

Code: Select all

#!/bin/bash
....
....
wget -q -O - http://$display/control?cmd=LCD,2,1,"Wilg.garaż:     $higro_garaz%"
...

it display only text-> Wilg.garaż: without content of variable.
I try for test change variable to fixed string but result was the same.

An next issue. Sending string (from bash too) with leading spaces causes that text is display without leading spaces.
Below the command

Code: Select all

nazwa="     Wyłączone"
wget -q -O - http://$display/control?cmd=LCD,2,1,"$nazwa"

[TD-er]

What happens when you try to send the same command from the tools page from that command line there?
After submitting, the URL in the browser will be updated with the exact formatting needed in the URL.

[TD-er]

About the leading spaces.... why not set the position (the 2nd argument)?
Or does it then not clear the previous text on those positions?

[mackowiakp]

About the leading spaces.... why not set the position (the 2nd argument)?
Or does it then not clear the previous text on those positions?

Because I have to clear beginning of line (not whole display)

What happens when you try to send the same command from the tools page from that command line there?
After submitting, the URL in the browser will be updated with the exact formatting needed in the URL.

Its display properly but please take into account that I want to pass variable to bash command line.
I try syntax like this:

Code: Select all

wget -q -O - http://$display/control?cmd='LCD,2,1,"Wilg.zewnątrz:  $higro%"'
and
wget -q -O - http://$display/control?cmd=LCD,2,1,'"Wilg.zewnątrz:  $higro%"'

with additional quota char ' but reuslt was in both cases that it display-> Wilg.zewnątrz: $higr

[Ath]

Bash doesn't expand variables wrapped in single quotes, AFAIR, this SO question has a quite usable explanation on that

[TD-er]

It isn't that hard to find out where in this part of the URL you need to replace stuff for your variables, right?

Code: Select all

Command: LCD,2,1,"Wilg.zewnątrz:  $higro%"
URL: /tools?cmd=LCD%2C2%2C1%2C"Wilg.zewnątrz%3A++%24higro%25"

Edit:
Ah now I get it, you need to replace it in the bash string.

[mackowiakp]

Hmmm... I changed order of quota charactrs in bash command from ` and " to " and `just like below

Code: Select all

wget -q -O - http://$display/control?cmd=LCD,2,1,"'Wilg.zewnątrz:  $higro%'"

and it works properly.
But the issue of leading spaces still exist

[Ath]

Parsing the arguments does by default a trim on the value. For the content part that should probably be changed (there's an extra argument that has to be set to false). I'll start a PR to change that soon (unless someone beats me to it )
Same goes for other Display-related plugins, I guess, I'll check that too.

[mackowiakp]

OK, but can I change this argument (which one?) to "false" by myself and compile new FW?

[Ath]

OK, but can I change this argument (which one?) to "false" by myself and compile new FW?

File _P012_LCD.ino, line 258:

Code: Select all

          String text = parseStringKeepCase(string, 4, ',', false);

[Ath]

I've created pull request #4536 that will correct this issue for this and other Display plugins that had the same behavior (P012, P023, P036, P104).

[mackowiakp]

THX

[mackowiakp]

New source code for P012 taken from request #4536 works properly on LCD display 4x20 and 2x16.
THX for quick correction!

[Ath]

Thanks for the feedback

[ewaldharmsen]

I am using this plugin today for the first time.

Thanks for the hard work

Its working fine except the brightness of the text.

I need to put the contrast all the way to one side to even see the text but its barely visible.

Anything I can do?

[TD-er]

Sounds like you might want to add a potentiometer to the contrast pin.
See: http://wiki.sunfounder.cc/index.php?tit ... 004_Module

Edit:
Apparently on the I2C to parallel add-on PCB is a potentiometer to set the contrast.
See: https://randomnerdtutorials.com/esp32-e ... duino-ide/

[ewaldharmsen]

Yes I have the potentiometer. If I turn it all the way I see something but not clearly.

[TD-er]

How is the display powered?
3V3 or 5V?

It looks like it needs 5V.
However, be aware that the SDA and SCL might be pulled up to the Vcc pin.
This means the SDA and SCL levels might be higher than 3V3.
The ESP may be able to handle this, but other sensors connected to this I2C bus might not be 5V tolerant.